evolix/ansible-roles
22
2
Fork 2
Code Issues 61 Pull requests 18 Releases 32 Wiki Activity

Add option to return the amp values #177

Merged
mgauthier merged 1 commit from munin_plugin_ipmi_with_amp into unstable 2024-04-12 17:04:53 +02:00
Conversation 2 Commits 1 Files changed 1 +224
mgauthier commented 2024-04-08 17:23:05 +02:00
Owner
Copy link

Modified version of the plugin to (optionally) return amp values.

Modified version of the plugin to (optionally) return amp values.
mgauthier requested review from jlecour 2024-04-11 22:03:40 +02:00
bwaegeneire commented 2024-04-12 16:55:20 +02:00
Owner
Copy link

Upstream script to help review the change, even tho it seems fine at first glance.

[Upstream script ](https://github.com/munin-monitoring/munin/blob/4cc19f61445c624a60cfc4702eca105f3982ad96/plugins/node.d/ipmi_#L7) to help review the change, even tho it seems fine at first glance.
bwaegeneire commented 2024-04-12 16:58:36 +02:00
Owner
Copy link

LGTM!

LGTM!
mgauthier force-pushed munin_plugin_ipmi_with_amp from 8c133ae37c to d11cf4987b 2024-04-12 17:03:41 +02:00 Compare
mgauthier changed title from WIP: Add option to return the amp values to Add option to return the amp values 2024-04-12 17:03:46 +02:00
mgauthier merged commit 7272106bce into unstable 2024-04-12 17:04:53 +02:00
mgauthier deleted branch munin_plugin_ipmi_with_amp 2024-04-12 17:04:53 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
jlecour
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
security

Concern a security issue

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/ansible-roles#177
No description provided.
Delete branch "munin_plugin_ipmi_with_amp"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?