evolix/evoadmin-web
22
0
Fork 1
Code Issues 31 Pull requests 4 Releases 1 Wiki Activity

[WIP] Add some test in CI to check that the code is clean #86

Draft
mtrossevin wants to merge 4 commits from ci-enablement into unstable
pull from: ci-enablement
merge into: evolix:unstable
Conversation 0 Commits 4 Files changed 10 +60 -17
mtrossevin commented 2023-11-13 15:28:01 +01:00
Owner
Copy link
No description provided.
mtrossevin added 2 commits 2023-11-13 15:28:03 +01:00
All checks were successful
Tests / PHPStan (static analysis) <sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)
Details
gitea/evoadmin-web/pipeline/head This commit looks good
Details
293ea73b6b
Initialise CI with PHPStan level 0
All checks were successful
Tests / PHPStan (static analysis) <sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)
Details
gitea/evoadmin-web/pipeline/head This commit looks good
Details
af94efde45
Replace isset($_POST) with !empty($_POST) 
The former is always true (outside of post method it is an empty array
and not null, and it cannot be `unset()`).

The check was as such either meaningless or was supposed to check that
something was sent. This commit assume the later.
mtrossevin added 1 commit 2023-11-15 10:59:01 +01:00
All checks were successful
Tests / PHPStan (static analysis) <sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)
Details
gitea/evoadmin-web/pipeline/pr-master This commit looks good
Details
7b29422730
Attempt to enable use of more than one agent 
Primarily so that we could use shellcheck in the future on top of
PHPStan.
mtrossevin changed title from [WIP] Add some test in CI to check that the code is clean to [WIP] Add some test in CI to check that the code is clean 2023-11-16 11:06:52 +01:00
mtrossevin changed target branch from master to unstable 2023-11-16 11:06:53 +01:00
mtrossevin added 1 commit 2023-11-16 11:07:03 +01:00
mtrossevin added the
Feature
 label 2023-11-17 14:43:19 +01:00
This pull request is marked as a work in progress.
This branch is out-of-date with the base branch
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin ci-enablement:ci-enablement
git checkout ci-enablement

Merge

Merge the changes and update on Forgejo.
git checkout unstable
git merge --no-ff ci-enablement
git checkout unstable
git merge --ff-only ci-enablement
git checkout ci-enablement
git rebase unstable
git checkout unstable
git merge --no-ff ci-enablement
git checkout unstable
git merge --squash ci-enablement
git checkout unstable
git merge --ff-only ci-enablement
git checkout unstable
git merge ci-enablement
git push origin unstable
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

Fixing or reporting bugs

  
Doc

Things that needs to be documented (use and/or dev)

  
Feature

Adding new features

  
Forge

Issues imported from https://forge.evolix.org/projects/evoadmin-web/issues

Archived

  
Mode
Cluster

  
Mode
MultiPHP

  
Script

Code that can be run both on the command line or by evoadmin

  
Server

Server configuration

  
Web

Code that is run on or by the http server.

  
wontfix
No labels
Bug
Doc
Feature
Forge
Mode
Cluster
Mode
MultiPHP
Script
Server
Web
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evoadmin-web#86
No description provided.
Delete branch "ci-enablement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?