evolix/evobackup
22
0
Fork 1
Code Issues 27 Pull requests 6 Releases 18 Activity

fix-tempfiles #72

Merged
jlecour merged 2 commits from fix-tempfiles into master 2024-03-22 11:27:36 +01:00
Conversation 0 Commits 2 Files changed 1 +4 -3
bwaegeneire commented 2024-03-22 10:20:22 +01:00
Owner
Copy link

Avoid littering / with tons of temporary files.

Avoid littering / with tons of temporary files.
bwaegeneire added 2 commits 2024-03-22 10:20:25 +01:00
9510546d48 client: Correctly clean up temporary files 
The function "build_rsync_main_cmd" is called in a subshell, so it can't
effectively modify it's parent variable "temp_files". To correctly cleanup
those temporary files, we do it when this specific function exits.
All checks were successful
gitea/evobackup/pipeline/head This commit looks good
Details
21533c6fb9 client: Write temporary files in /tmp 
By default "mktemp" creates a temporary file in the current working directory,
which in the context of Debian's cron is /. To avoid littering /, we add the
option "--tmpdir" that use $TMPDIR or /tmp instead.
jlecour merged commit 859bb800d4 into master 2024-03-22 11:27:36 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bkctld

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

  
zzz_evobackup
No labels
bkctld
bug
duplicate
enhancement
invalid
question
wontfix
zzz_evobackup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evobackup#72
No description provided.
Delete branch "fix-tempfiles"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?