evolix/evobackup
22
0
Fork 1
Code Issues 27 Pull requests 6 Releases 18 Activity

Append pidfile to temp_files #71

Closed
abenmiloud wants to merge 3 commits from remove_temp_files into master
pull from: remove_temp_files
merge into: evolix:master
Conversation 3 Commits 3 Files changed 1 +1 -1
abenmiloud commented 2024-01-04 16:37:44 +01:00
Owner
Copy link

This commit fixes a bug where evobackup does not remove all its
temporary files.

This commit fixes a bug where evobackup does not remove all its temporary files.
abenmiloud added 1 commit 2024-01-04 16:37:46 +01:00
All checks were successful
gitea/evobackup/pipeline/head This commit looks good
Details
60fc49ad0f Append pidfile to temp_files 
This commit fixes a bug where evobackup does not remove all its
temporary files.
jlecour commented 2024-01-04 17:06:47 +01:00
Owner
Copy link

I'm pretty sure this fix is correct.

Although this is fixed in a different way in the next branch (client-functions) of evobackup

I'm pretty sure this fix is correct. Although this is fixed in a different way in the next branch (`client-functions`) of evobackup
mtrossevin approved these changes 2024-01-04 17:25:52 +01:00
mtrossevin left a comment
Owner
Copy link

Seems fine.

Seems fine.
abenmiloud added 2 commits 2024-01-05 18:07:28 +01:00
50b5af6095 Revert last fix 
It breaks the backup. Because of `set -u`, we can initialize
temp_files using temp_files.
All checks were successful
gitea/evobackup/pipeline/head This commit looks good
Details
e2c50f00d4 Avoid variable substitution at trap definition 
This should fix the temporary files removal.
abenmiloud commented 2024-01-05 18:10:10 +01:00
Author
Owner
Copy link

My first commit broke the backup script. The temporary files removal should be fixed the right way now.

My first commit broke the backup script. The temporary files removal should be fixed the right way now.
bwaegeneire commented 2024-03-22 10:22:30 +01:00
Owner
Copy link

I've tested this PR, it doesn't fix what it ought to, so I'm closing it.

It is replaced by the PR #72 which does fix the temporary files issue.

I've tested this PR, it doesn't fix what it ought to, so I'm closing it. It is replaced by the PR #72 which does fix the temporary files issue.
bwaegeneire closed this pull request 2024-03-22 10:22:30 +01:00
All checks were successful
gitea/evobackup/pipeline/head This commit looks good
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
mtrossevin
Labels
Clear labels   
bkctld

   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

  
zzz_evobackup
No labels
bkctld
bug
duplicate
enhancement
invalid
question
wontfix
zzz_evobackup
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evobackup#71
No description provided.
Delete branch "remove_temp_files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?