Add check-incs.sh to verify incs #14

jlecour · 2019-03-29T18:22:15+01:00

jlecour commented

2019-03-29 18:22:15 +01:00

No description provided.

benpro reviewed 2019-04-01 11:35:52 +02:00

check-incs.sh

					
				@ -0,0 +15,4 @@

				    ls -d /backup/incs/$1 > /dev/null 2>&1 

				}

				jail_exists() {

				    ls -d /backup/jails/$1 > /dev/null 2>&1

benpro commented

2019-04-01 11:34:24 +02:00

Why not test -d? Oo

Why not `test -d`? Oo

jlecour commented

2019-04-03 11:57:03 +02:00

To be consistent with inc_exists where we need to support globbing.

To be consistent with `inc_exists` where we need to support globbing.

benpro commented

2019-04-03 12:04:47 +02:00

OK. Or, you could loop in place of using inc_exists ${jail_name}/${inc_date}*;.

OK. Or, you could loop in place of using `inc_exists ${jail_name}/${inc_date}*;`.

jlecour commented

2019-04-03 21:15:00 +02:00

I don't understand what you mean.
If you think it's worth investigating, maybe you could post a complete example, to show what is better in the context.

I don't understand what you mean. If you think it's worth investigating, maybe you could post a complete example, to show what is better in the context.

benpro commented

2019-04-04 15:56:34 +02:00

See: #18.