evolix/evobackup
22
0
Fork 1
Code Issues 28 Pull requests 5 Releases 20 Activity

WIP: Loop version of check-incs using test -d #18

Closed
benpro wants to merge 1 commit from check-incs-loop into check-incs
pull from: check-incs-loop
merge into: evolix:check-incs
Conversation 0 Commits 1 Files changed 1 +6 -3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
check-incs.sh
View file

@ -1,4 +1,5 @@
#!/bin/sh
shopt -s nullglob
EVOBACKUP_CONFIGS="/etc/evobackup/*"
@ -12,10 +13,10 @@ relative_date() {
echo ${past_date}
}
inc_exists() {
ls -d /backup/incs/$1 > /dev/null 2>&1
test -d /backup/incs/$1
}
jail_exists() {
ls -d /backup/jails/$1 > /dev/null 2>&1
test -d /backup/jails/$1
}
# default return value is 0 (succes)
rc=0
@ -34,11 +35,13 @@ for file in ${EVOBACKUP_CONFIGS}; do
inc_age=$(date --date "${inc_date}" +%s)
# check if the configuration changed after the inc date
if [ $jail_config_age -lt $inc_age ]; then
for inc in ${jail_name}/${inc_date}*; do
benpro commented 2019-04-04 16:02:41 +02:00
Review
Copy link

One issue though: If there is no folder/incs, the loop is silently skipped (nullglob).
Maybe add a test before and says : Error: No incs at all for this jail!

One issue though: If there is no folder/incs, the loop is silently skipped (nullglob). Maybe add a test before and says : Error: No incs at all for this jail!
# Error if inc is not found
if ! inc_exists ${jail_name}/${inc_date}*; then
if ! inc_exists ${inc}; then
echo "ERROR: inc is missing \`${jail_name}/${inc_date}'" >&2
rc=1
fi
done
else
echo "INFO: no inc expected for ${inc_date} \`${jail_name}'"
fi