Adding LOGFILE variable #27

Merged

jlecour merged 1 commit from variable-for-log-and-pidfile into master

2019-08-22 10:38:28 +02:00

benpro commented

2019-07-10 14:31:26 +02:00

Contributor

This is way better than hardcoding log file path.

benpro added the

enhancement

label 2019-07-10 14:31:26 +02:00

benpro commented

2019-07-10 14:31:37 +02:00

Author

Contributor

@vlaborie Review and merge welcome

jlecour commented

2019-07-10 17:17:29 +02:00

Owner

I know it's not that important but we should put braces around variables, like this : ${LOGFILE}.

Other than that, I really like this kind of commits. It make the code so much more maintainable and less error prone. 👏

I know it's not that important but we should put braces around variables, like this : `${LOGFILE}`. Other than that, I really like this kind of commits. It make the code so much more maintainable and less error prone. :clap:

benpro commented

2019-07-10 17:43:26 +02:00

Author

Contributor

You should use braces when needed. For braces expansion like ${foo:-bar} or for concatenation like echo foo${bar}.

Here, there is no need for braces. 😑

You should use braces when needed. For braces expansion like `${foo:-bar}` or for concatenation like echo `foo${bar}`. Here, there is no need for braces. :expressionless:

benpro commented

2019-07-10 17:46:22 +02:00

Author

Contributor

I'm against using braces anytime. 😩

I'm against using braces anytime. :weary: