evolix/evobackup
22
0
Fork 1
Code Issues 28 Pull requests 5 Releases 21 Activity

Fix quoting and escaping shellcheck errors #38

Manually merged
Ghost merged 2 commits from shellcheck-escapes into master 2020-04-21 15:05:13 +02:00
Conversation 2 Commits 2 Files changed 1 +12 -10
1 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
zzz_evobackup
View file

@ -83,7 +83,7 @@ test_server() {
else else
# SSH connection failed # SSH connection failed
new_error=$(printf "Failed to connect to \`%s' within %s seconds" "${item}" "${SSH_CONNECT_TIMEOUT}") new_error=$(printf "Failed to connect to \`%s' within %s seconds" "${item}" "${SSH_CONNECT_TIMEOUT}")
SERVERS_SSH_ERRORS=$(printf "%s\n%s" "${SERVERS_SSH_ERRORS}" "${new_error}" | sed -e '/^$/d') SERVERS_SSH_ERRORS=$(printf "%s\\n%s" "${SERVERS_SSH_ERRORS}" "${new_error}" | sed -e '/^$/d')
jlecour commented 2020-04-16 08:22:01 +02:00
Review
Copy link

I'm not sure printf likes to see escaped line breaks. Did you test this? Did it work?

I'm not sure printf likes to see escaped line breaks. Did you test this? Did it work?
Ghost commented 2020-04-20 18:05:37 +02:00
Review
Copy link

I've just tested manually and it worked, we will see tomorrow if it worked when run from cron.

I've just tested manually and it worked, we will see tomorrow if it worked when run from cron.
return 1 return 1
fi fi
@ -96,16 +96,16 @@ pick_server() {
if [ "${increment}" -ge "${list_length}" ]; then if [ "${increment}" -ge "${list_length}" ]; then
# We've reached the end of the list # We've reached the end of the list
new_error="No more server available" new_error="No more server available"
SERVERS_SSH_ERRORS=$(printf "%s\n%s" "${SERVERS_SSH_ERRORS}" "${new_error}" | sed -e '/^$/d') SERVERS_SSH_ERRORS=$(printf "%s\\n%s" "${SERVERS_SSH_ERRORS}" "${new_error}" | sed -e '/^$/d')
# Log errors to stderr # Log errors to stderr
printf "%s\n" "${SERVERS_SSH_ERRORS}" >&2 printf "%s\\n" "${SERVERS_SSH_ERRORS}" >&2
# Log errors to logfile # Log errors to logfile
printf "%s\n" "${SERVERS_SSH_ERRORS}" >> $LOGFILE printf "%s\\n" "${SERVERS_SSH_ERRORS}" >> $LOGFILE
return 1 return 1
fi fi
# Extract the day of month, without leading 0 (which would give an octal based number) # Extract the day of month, without leading 0 (which would give an octal based number)
today=$(date +%e) today=$(date +%e)
# A salt is useful to randomize the starting point in the list # A salt is useful to randomize the starting point in the list
# but stay identical each time it's called for a server (based on hostname). # but stay identical each time it's called for a server (based on hostname).
@ -123,14 +123,14 @@ pick_server() {
if [ -e "${PIDFILE}" ]; then if [ -e "${PIDFILE}" ]; then
pid=$(cat "${PIDFILE}") pid=$(cat "${PIDFILE}")
# Does process still exist ? # Does process still exist ?
if kill -0 ${pid} 2> /dev/null; then if kill -0 "${pid}" 2> /dev/null; then
Ghost commented 2020-04-20 18:20:46 +02:00
Review
Copy link

Fixed

Fixed
# Killing the childs of evobackup. # Killing the childs of evobackup.
for ppid in $(pgrep -P "${pid}"); do for ppid in $(pgrep -P "${pid}"); do
kill -9 "${ppid}"; kill -9 "${ppid}";
done done
# Then kill the main PID. # Then kill the main PID.
kill -9 "${pid}" kill -9 "${pid}"
printf "%s is still running (PID %s). Process has been killed" "$0" "${pid}\n" >&2 printf "%s is still running (PID %s). Process has been killed" "$0" "${pid}\\n" >&2
else else
rm -f ${PIDFILE} rm -f ${PIDFILE}
fi fi
@ -299,7 +299,7 @@ if [ "${LOCAL_TASKS}" = "1" ]; then
## Dump findmnt(8) output ## Dump findmnt(8) output
FINDMNT_BIN=$(command -v findmnt) FINDMNT_BIN=$(command -v findmnt)
if [ -x ${FINDMNT_BIN} ]; then if [ -x "${FINDMNT_BIN}" ]; then
${FINDMNT_BIN} > ${LOCAL_BACKUP_DIR}/findmnt.txt ${FINDMNT_BIN} > ${LOCAL_BACKUP_DIR}/findmnt.txt
fi fi
else else
@ -366,6 +366,8 @@ if [ "${SYNC_TASKS}" = "1" ]; then
# Remote shell command # Remote shell command
RSH_COMMAND="ssh -p ${SSH_PORT} -o 'ConnectTimeout ${SSH_CONNECT_TIMEOUT}'" RSH_COMMAND="ssh -p ${SSH_PORT} -o 'ConnectTimeout ${SSH_CONNECT_TIMEOUT}'"
# ignore check because we want it to split the different arguments to $rep
# shellcheck disable=SC2086
rsync -avzh --stats --delete --delete-excluded --force --ignore-errors --partial \ rsync -avzh --stats --delete --delete-excluded --force --ignore-errors --partial \
--exclude "lost+found" \ --exclude "lost+found" \
--exclude ".nfs.*" \ --exclude ".nfs.*" \
@ -410,11 +412,11 @@ fi
END=$(/bin/date +"%d-%m-%Y ; %H:%M") END=$(/bin/date +"%d-%m-%Y ; %H:%M")
printf "EvoBackup - %s - START %s ON %s (LOCAL_TASKS=%s SYNC_TASKS=%s)\n" \ printf "EvoBackup - %s - START %s ON %s (LOCAL_TASKS=%s SYNC_TASKS=%s)\\n" \
"${HOSTNAME}" "${BEGINNING}" "${SSH_SERVER}" "${LOCAL_TASKS}" "${SYNC_TASKS}" \ "${HOSTNAME}" "${BEGINNING}" "${SSH_SERVER}" "${LOCAL_TASKS}" "${SYNC_TASKS}" \
>> $LOGFILE >> $LOGFILE
printf "EvoBackup - %s - STOP %s ON %s (LOCAL_TASKS=%s SYNC_TASKS=%s)\n" \ printf "EvoBackup - %s - STOP %s ON %s (LOCAL_TASKS=%s SYNC_TASKS=%s)\\n" \
"${HOSTNAME}" "${END}" "${SSH_SERVER}" "${LOCAL_TASKS}" "${SYNC_TASKS}" \ "${HOSTNAME}" "${END}" "${SSH_SERVER}" "${LOCAL_TASKS}" "${SYNC_TASKS}" \
>> $LOGFILE >> $LOGFILE