Jérémy Lecour
2fdc3338fd
Disable a few shellcheck style warnings
2019-03-23 02:36:42 +01:00
Jérémy Lecour
a7bfbe0a19
awk
instead of tr | cut
2019-03-23 02:36:42 +01:00
Jérémy Lecour
3591e265c8
grep -c
instead of grep | wc -l
2019-03-23 02:36:42 +01:00
Jérémy Lecour
92754deef0
whitespaces
2019-03-23 02:36:42 +01:00
Jérémy Lecour
8f46b6c811
variable extraction
2019-03-23 02:36:42 +01:00
Jérémy Lecour
97b13b2a60
cut < file
instead of cat file | cut
2019-03-23 02:36:42 +01:00
Jérémy Lecour
fa53e1a293
command grouping with braces
2019-03-23 02:36:42 +01:00
Jérémy Lecour
1c0f00c473
quotes
2019-03-23 02:36:42 +01:00
Jérémy Lecour
9861e22614
test command return value directly
2019-03-23 02:36:42 +01:00
Jérémy Lecour
8254877240
Add IS_ETCGIT to check for /etc.git Git repository
2019-03-23 02:36:42 +01:00
Jérémy Lecour
ae0b3ae2f1
Use bc (instead of python) to have a rounded percentage
2019-03-23 02:36:42 +01:00
Jérémy Lecour
4f8a9ceecc
fix quotes
2019-03-23 02:36:42 +01:00
Jérémy Lecour
a8178598e9
use braces instead of parenthesis
2019-03-23 02:36:41 +01:00
Jérémy Lecour
3a484cf694
add quotes
2019-03-23 02:36:41 +01:00
Jérémy Lecour
c073f5ca87
homeDir is useless here
2019-03-23 02:36:41 +01:00
Jérémy Lecour
0fe664f571
rework the EVOACME check
2019-03-23 02:36:41 +01:00
Jérémy Lecour
55f720972b
add a lot of verbose output
2019-03-23 02:36:41 +01:00
Jérémy Lecour
8957b19a96
reorganize IS_EVOMAINTENANCEUSERS
2019-03-23 02:36:41 +01:00
Jérémy Lecour
4a70693114
conditional readability
2019-03-23 02:36:41 +01:00
Jérémy Lecour
cfb4602bed
extract variable
2019-03-23 02:36:41 +01:00
Jérémy Lecour
5b9d41de0c
wording
2019-03-23 02:36:41 +01:00
Jérémy Lecour
76354bed48
extract variable
2019-03-23 02:36:41 +01:00
Jérémy Lecour
a01b53111d
OpenBSD version detection
2019-03-23 02:36:41 +01:00
Jérémy Lecour
8aadbed4de
Don't limit to Lenny
...
This test doesn't seem to be limited to Lenny, so we should check for
all backports
2019-03-23 02:36:41 +01:00
Jérémy Lecour
c2fda32d0d
extract main conditional
2019-03-23 02:36:41 +01:00
Jérémy Lecour
3b8617b20c
use grep -s
instead of redirecting stderr
2019-03-23 02:36:41 +01:00
Jérémy Lecour
7cb7a47be7
improve readability
2019-03-23 02:36:41 +01:00
Jérémy Lecour
0afdfbf3a1
Use braces instead for command grouping.
...
It avoids subshells
2019-03-23 02:36:40 +01:00
Jérémy Lecour
9658e531ad
quotes
2019-03-23 02:36:40 +01:00
Jérémy Lecour
2267b79618
remove unused IS_TOOMUCHDEBIANSYSMAINT
2019-03-23 02:36:40 +01:00
Jérémy Lecour
fc3d2e28cf
APACHEMUNIN: muunin config can be in other files
2019-03-23 02:36:40 +01:00
Jérémy Lecour
a4c1629912
verbose comments for RAID checks
2019-03-23 02:36:40 +01:00
Jérémy Lecour
d51c64d410
reorganize IS_APACHEMUNIN
2019-03-23 02:36:40 +01:00
Jérémy Lecour
3353096ebe
don't use a sub shell for IS_REPVOLATILE
2019-03-23 02:36:40 +01:00
Jérémy Lecour
366fc03237
print duplicate labels on a single line
2019-03-23 02:36:40 +01:00
Jérémy Lecour
9b31ab030e
fix "is_debian_lenny"
2019-03-23 02:36:40 +01:00
Jérémy Lecour
2ad82591f3
test if it's a file, to ignore directories
2019-03-23 02:36:40 +01:00
Jérémy Lecour
c3b4efd71e
fix debian version detection for IS_LSBRELEASE
2019-03-23 02:36:40 +01:00
Jérémy Lecour
e525141ae4
move VERBOSE block to log comment
2019-03-23 02:36:40 +01:00
Jérémy Lecour
419ecbc10f
fix conditions grouping
2019-03-23 02:36:40 +01:00
Jérémy Lecour
367756d6b2
variables extraction
2019-03-23 02:36:40 +01:00
Jérémy Lecour
99ddd1a05c
better test ordering
2019-03-23 02:36:40 +01:00
Jérémy Lecour
3e14210a0b
extract if
2019-03-23 02:36:40 +01:00
Jérémy Lecour
9dcdd8202e
more permissions check with stat
2019-03-23 02:36:40 +01:00
Jérémy Lecour
057cb7026a
even more quotes
2019-03-23 02:36:40 +01:00
Jérémy Lecour
0fc9d0921e
grep can count occurrences too
2019-03-23 02:36:40 +01:00
Jérémy Lecour
ae12b37c7f
add verbose comments for IS_BACKPORTSCONF
2019-03-23 02:36:40 +01:00
Jérémy Lecour
830db4743c
more quotes
2019-03-23 02:36:40 +01:00
Jérémy Lecour
38b0342d0c
use stat
instead of ls -l | grep
2019-03-23 02:36:10 +01:00
Jérémy Lecour
00311e8f0e
quote
2019-03-23 02:36:10 +01:00
Jérémy Lecour
fa79f1d1a8
big cleanup
...
* tests organization
* shellcheck conventions
* variables extractions
* quotes and indentations
2019-03-23 02:36:10 +01:00
Jérémy Lecour
2c44db77a3
replace `` with $()
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
2019-03-23 02:30:18 +01:00
Jérémy Lecour
720ea03b0c
Add IS_LSBRELEASE check
2019-03-23 02:29:24 +01:00
Jérémy Lecour
36fa3af815
replace old-fashioned tests with functions
2019-03-23 02:29:24 +01:00
Jérémy Lecour
d3cb743f76
MINIFW_FILE for Debian Lenny
2019-03-23 02:28:53 +01:00
Jérémy Lecour
1b4b2a2ff8
workaround possibly missing lsb_release command
2019-03-23 02:28:53 +01:00
Jérémy Lecour
9c4a40b585
optimize OS/release/version detection
2019-03-23 02:28:53 +01:00
Jérémy Lecour
da2b48d792
no tabs, but 4 spaces
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
2019-03-21 21:19:53 +01:00
Jérémy Lecour
b7ce862073
fix indentation levels
2019-03-21 21:15:48 +01:00
Jérémy Lecour
f3caffc9d5
Improve logging with optional verbose comment ( #71 )
continuous-integration/drone/push Build is failing
2019-03-21 14:27:34 +01:00
Benoît S.
7cc422974a
IS_NOTUPGRADED: Better detection of upgrades
...
continuous-integration/drone/push Build is failing
continuous-integration/drone/pr Build is failing
Fix #66
2019-03-05 11:27:53 +01:00
Benoît S.
cf8ad6c4d8
Merge branch '62-IS_NOTUPGRADED-quiet-grep' of evolix/evocheck into master
2019-02-22 10:31:38 +01:00
Benoît S.
f783d2bb3f
Quiet grep by adding -s
...
Otherwhise it would ouput
`grep: /etc/evolinux/listupgrade.cnf: No such file or directory`.
2019-02-21 15:59:21 +01:00
Benoît S.
a6ee33004e
Closes #59 IS_MYSQLUTILS: Fixed wrong logic ( #60 )
2019-02-20 17:52:30 +01:00
Benoît S.
3f0b40e34e
Merge branch '54-fixes-IS_LISTCHANGESCONF-verbose-mode' of evolix/evocheck into master
2019-02-19 15:07:24 +01:00
Benoît S.
65c97eb7be
Fixes and closes #29 by adding silent grep
2019-02-19 11:24:01 +01:00
Benoît S.
62bcb5a71d
Fixes #54 by refactoring IS_LISTCHANGESCONF
...
Verbose mode previously added was misbehaving.
Also refactored the code for more readability.
2019-02-19 10:43:51 +01:00
Benoît S.
9be91392f3
Merge branch 'IS_EVOLIX_USER-do-not-use-getent' of evolix/evocheck into master
2019-02-14 11:19:32 +01:00
Benoît S.
2fe9d4ea0e
Merge branch 'IS_BACKPORTSCONF-really-quiet-grep' of evolix/evocheck into master
2019-02-14 11:19:19 +01:00
Benoît S.
7ccf640e4c
Merge branch 'IS_DUPLICATE_FS_LABEL-exclude-EFI_SYSPART' of evolix/evocheck into master
2019-02-14 11:18:57 +01:00
Benoît S.
b7c3b3fadc
Merge branch 'IS_DUPLICATE_FS_LABEL-add-verbose-mode' of evolix/evocheck into master
2019-02-14 11:18:41 +01:00
Benoît S.
38c8c75248
IS_EVOLIX_USER: Do not use getent
...
Why? Because of LDAP. It is normal to have an evolix user in LDAP but not in
`/etc/passwd`.
2019-02-12 12:48:28 +01:00
Benoît S.
1aad813663
IS_BACKPORTSCONF: Quiet grep and better readability
...
Added `-s` to grep to not have error messages like:
`grep: /etc/apt/preferences.d/*: No such file or directory`
And don't use `2>/dev/null` as there is `-s` grep option!
Added if condition for better readability of the code.
2019-02-12 12:38:11 +01:00
Benoît S.
77afe63bc5
IS_DUPLICATE_FS_LABEL: Exclude EFI_SYSPART
...
EFI_SYSPART is (and should be) on all disks when using soft raid.
2019-02-12 12:10:42 +01:00
Benoît S.
a099ba5f40
IS_DUPLICATE_FS_LABEL: Add verbose mode
2019-02-12 12:03:59 +01:00
Benoît S.
1a3e1615a8
Fix #42 By using better logic
...
If the system hasn't received any upgrade, check the install date.
2019-02-12 11:48:56 +01:00
Benoît S.
a9d26a49b4
Merge branch 'verbose-islistchangesconf' of evolix/evocheck into master
2019-02-01 14:41:16 +01:00
Jérémy Lecour
f3b5e8f9b7
echo needs to be there only once
2019-01-30 18:06:28 +01:00
Jérémy Lecour
83f4b01789
Add verbose message for IS_LISTCHANGESCONF
2019-01-30 17:49:57 +01:00
Victor Laborie
fd5b9cd86c
Merge branch 'IS_EVOMAINTENANCEUSERS-verbose-mode' of evolix/evocheck into master
2019-01-25 11:32:21 +01:00
Benoît S.
fbce70f906
New version of IS_EVOMAINTENANCEUSERS
...
Verbose mode added
Break added
Better readability
2019-01-25 11:11:16 +01:00
Benoît S.
d1317eb087
This new version exclude .bak and .date directories.
2019-01-25 10:40:51 +01:00
Benoît S.
5fc78550f3
Better readability and verbose messages
2019-01-18 15:14:40 +01:00
Benoît S.
fd11189400
Merge branch 'master' into 17-IS_MYSQLUTILS-with-oracle-MySQL5.7
2019-01-18 14:50:12 +01:00
Benoît S.
0a3ae1ceca
Merge branch '47-is_notupgraded-var-log-evolinux-00_prepare_system-log-is-deprecated'
2019-01-17 15:30:55 +01:00
Victor LABORIE
671bdbd92b
Rewrite IS_OLD_HOME_DIR with find (fix output order in verbose mode)
2019-01-17 11:55:51 +01:00
Victor LABORIE
6bfe6eb9a7
Fix odd return line in verbose mode
2019-01-17 11:02:44 +01:00
Victor LABORIE
3cfa884a6f
Add a verbose function and use it for some checks ( Fix #30 )
2019-01-16 17:10:51 +01:00
Victor Laborie
c15f959c22
Merge branch '25-Detect-old-home-dir' of evolix/evocheck into master
2019-01-16 16:48:23 +01:00
Benoît S.
d027b521a6
Missing underscore
2019-01-16 15:58:46 +01:00
Benoît S.
a4c3916545
Fix issue #17
...
- `MYSQL_ADMIN` is now a variable because some installation doesn't have `mysqladmin`
user.
- `/usr/bin/mytop` or `/usr/local/bin/mytop` are checked.
2019-01-16 15:20:03 +01:00
Benoît S.
d338fc7e9b
Fix #14 by adding a break
...
We need to break to display only one error message.
2019-01-16 14:24:35 +01:00
Benoît S.
48561592ee
Replace and condition by or condition
...
Check install_date or last_upgrade, because if you never upgraded you will
never match the limit
2019-01-16 14:12:12 +01:00
Benoît S.
288d26366a
Implement #25
...
We loop through directories in /home and see ig the owner has a resolvable ID.
2019-01-16 13:47:49 +01:00
Victor LABORIE
96336afca5
Detect comment for IS_BACKPORTSCONF ( Fix #28 )
2018-12-21 15:52:17 +01:00
Victor LABORIE
db1d4e4aae
Add a break to IS_PRIVKEYWOLRDREADABLE ( Fix #19 )
2018-12-21 15:29:20 +01:00
Victor LABORIE
7179cfefc8
Remove "No such file or directory" error on IS_NOTUPGRADED check
2018-12-21 15:22:30 +01:00
Victor LABORIE
22d835b733
Follow symlink for IS_PRIVKEYWOLRDREADABLE check
2018-12-19 16:18:50 +01:00
Benoît S.
956877442a
WIP: Removes /var/log/evolinux/00_prepare_system.log
...
TODO: Workaround in special case when the server was never installed
TODO: be sure that the final check with and logic is OK.
2018-09-14 15:52:08 +02:00
Jérémy Lecour
ffecb8a7c4
grep regular expressions must be quoted
2018-08-17 15:26:55 +02:00