evolix/evocheck

Fork 2

Basic OpenBSD checks and first OpenBSD release #4

New issue

Open

opened 2018-12-20 10:19:13 +01:00 by benpro · 9 comments

benpro commented

2018-12-20 10:19:13 +01:00

Contributor

sudo/doas config
Right mirror for packages
newsyslog config
evomaintenance config

- [ ] sudo/doas config - [ ] Right mirror for packages - [ ] newsyslog config - [ ] evomaintenance config

benpro added the

enhancement

label 2018-12-20 10:19:13 +01:00

benpro changed title from ~~Basic OpenBSD checks~~ to Basic OpenBSD checks and first OpenBSD release

2018-12-20 10:20:02 +01:00

benpro commented

2018-12-20 10:21:05 +01:00

Author

Contributor

Relation: https://redmine.evolix.net/issues/4284

benpro commented

2019-03-13 10:21:12 +01:00

Author

Contributor

Suggestion: OpenBSD version should be totally separate from "Debian" code and contains only OpenBSD checks.
It could live on a new project, or in a OpenBSD branch.

Suggestion: OpenBSD version should be totally separate from "Debian" code and contains only OpenBSD checks. It could live on a new project, or in a OpenBSD branch.

Ghost commented

2019-03-13 10:23:12 +01:00

An OpenBSD separate branch sounds better to me

Ghost commented

2019-03-13 15:42:41 +01:00

Would it not be more interesting to separate the checks into folders? Maybe even have one file per check. You could define an OpenBSD folder, a Debian folder and a Posix folder.

Checks that work on both go in Posix and so on and so forth.

Would it not be more interesting to separate the checks into folders? Maybe even have one file per check. You could define an OpenBSD folder, a Debian folder and a Posix folder. Checks that work on both go in Posix and so on and so forth.

benpro commented

2019-03-13 16:42:46 +01:00

Author

Contributor

It may be the case in the future. I opened #68.
One idea of @jlecour was to do something like munin plugins with symbolic links to enable a check.

It may be the case in the future. I opened #68. One idea of @jlecour was to do something like munin plugins with symbolic links to enable a check.

benpro added a new dependency 2019-03-13 16:42:58 +01:00

#68 Split every checks in their own files

gcolpart commented

2019-03-13 17:32:29 +01:00

Owner

I like evocheck.sh is one-readable-file.
What is the interest to split in this case?

I like evocheck.sh is one-readable-file. What is the interest to split in this case?

Ghost commented

2019-03-13 18:52:06 +01:00

The main reason would be to make it easier to interact with from the command line.

Want active checks? ls enabled_checks

Want openbsd checks? ls checks/openbsd

Want to find a check related to apache? find checks -name '*apache*'

Want to read a check? cat check/is_evolix_user.sh

Want to read all checks? cat check/* check/*/*

This is definitely all possible with one single file by using grep(1), but I feel like it requires more knowledge of the structure of the file and various flags.

The second use is that every single conditional branch in a program is another potential bug and using symbolic links allows us to remove most, if not all, if is enabled style checks. I believe this would also make these checks more readable.

The main reason would be to make it easier to interact with from the command line. Want active checks? `ls enabled_checks` Want openbsd checks? `ls checks/openbsd` Want to find a check related to apache? `find checks -name '*apache*'` Want to read a check? `cat check/is_evolix_user.sh` Want to read all checks? `cat check/* check/*/*` This is definitely all possible with one single file by using grep(1), but I feel like it requires more knowledge of the structure of the file and various flags. The second use is that every single conditional branch in a program is another potential bug and using symbolic links allows us to remove most, if not all, `if is enabled` style checks. I believe this would also make these checks more readable.

gcolpart commented

2019-03-21 14:01:44 +01:00

Owner

I don't see why/when do you want list openbsd/apache/etc. checks.
For all checks, it's grep IS_ evocheck.sh
For active checks, it's all minus /etc/evocheck.sh

For others arguments, I understand but you loose the advantage to keep one-readable-file which is very important in the case of evocheck (not in general of course)

I don't see why/when do you want list openbsd/apache/etc. checks. For all checks, it's grep IS_ evocheck.sh For active checks, it's all minus /etc/evocheck.sh For others arguments, I understand but you loose the advantage to keep one-readable-file which is very important in the case of evocheck (not in general of course)

Ghost commented

2019-03-21 15:12:14 +01:00

For others interested in talking about the check = file issue, please see here: #68 (comment)

For others interested in talking about the check = file issue, please see here: https://gitea.evolix.org/evolix/evocheck/issues/68#issuecomment-4040