Optimize OS/release/version detection for faster execution #70

jlecour · 2019-03-20T21:58:27+01:00

jlecour commented

2019-03-20 21:58:27 +01:00

Related to #69

benpro added a new dependency 2019-03-21 10:36:35 +01:00

#69 Don't execute `lsb_release` more than once

benpro reviewed 2019-03-21 10:46:41 +01:00

evocheck.sh Outdated

					
				@ -128,0 +130,4 @@

				if [ -e /etc/debian_version ]; then

				    DEBIAN_RELEASE=$(lsb_release -c -s)

				    DEBIAN_VERSION=$(cat /etc/debian_version |cut -d "." -f 1)

benpro commented

2019-03-21 10:42:42 +01:00

Useless cat+pipe.

cut -d "." -f 1 < /etc/debian_version

Useless cat+pipe. ``` cut -d "." -f 1 < /etc/debian_version ```

evocheck.sh Outdated

					
				@ -162,0 +186,4 @@

				    test "${DEBIAN_RELEASE}" = "stretch"

				}

				debian_release() {

				    printf "%s" "${DEBIAN_RELEASE}"

benpro commented

2019-03-21 10:45:46 +01:00

printf is very useful when you want to replace many strings, but for one?

echo "${DEBIAN_RELEASE}"

is largely sufficient.

printf is very useful when you want to replace many strings, but for one? ``` echo "${DEBIAN_RELEASE}" ``` is largely sufficient.

jlecour commented

2019-03-21 13:50:47 +01:00

there is the question of the newline at the end, and I can't remember is it's a POSIX option.

benpro commented

2019-03-21 14:19:37 +01:00

You mean echo -n?
BTW this function is not used? I don't see any call.

You mean `echo -n`? BTW this function is not used? I don't see any call.

benpro added the

enhancement

label 2019-03-21 10:54:19 +01:00

benpro was assigned by jlecour

2019-03-21 12:54:41 +01:00

jlecour commented

2019-03-21 21:12:12 +01:00

I've rebased on master to resolve conflicts

benpro reviewed 2019-03-22 10:00:26 +01:00

jlecour reviewed 2019-03-23 02:23:45 +01:00

jlecour left a comment

It would be cool to merge this PR, so we could focus on the others based on this one.

jlecour commented

2019-03-23 02:33:03 +01:00

@benpro You're right, the rebase was messed up. I've done it again. I hope it's good this time.

benpro reviewed 2019-04-03 10:00:20 +02:00

evocheck.sh

benpro commented

2019-04-03 10:00:20 +02:00

Beware it has moved at line 162.

benpro approved these changes 2019-04-03 10:01:59 +02:00

benpro commented

2019-04-03 10:02:40 +02:00

LGTM. @vlaborie Review welcome.

jlecour commented

2019-04-03 21:22:52 +02:00

@vlaborie tell me if you'd like to do a pair-review.

jlecour commented

2019-04-04 18:37:34 +02:00

@benpro: Let's merge this, and then merge #75

benpro closed this pull request

2019-04-05 11:01:57 +02:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on

#69 Don't execute `lsb_release` more than once

evolix/evocheck

Reference: evolix/evocheck#70