whitespaces normalization #72

jlecour · 2019-03-20T22:56:39+01:00

jlecour commented

2019-03-20 22:56:39 +01:00

no tabs (4 spaces)
indentation for split lines

* no tabs (4 spaces) * indentation for split lines

benpro reviewed 2019-03-21 10:34:30 +01:00

evocheck.sh

					
				@ -904,3 +902,2 @@

				            if [[ -n "$statResult" ]]; then

				            if [ -n "$statResult" ]; then

				                echo 'IS_OLD_HOME_DIR FAILED!'

				                if [[ "$VERBOSE" == 1 ]]; then

benpro commented

2019-03-21 10:34:20 +01:00

In this case, this is pure appreciated bashism.
I like to use the double brackets because of "Using the ... test construct, rather than [ ... ] can prevent many logic errors in scripts. For example, the &&, ||, <, and > operators work within a test, despite giving an error within a [ ] construct."
https://www.tldp.org/LDP/abs/html/abs-guide.html#DBLBRACKETS

I use [[ ]] all the time. Except if the script has already a single bracket, I will not "recode" it with double brackets.

Good Practice:
Whenever you're making a Bash script, you should always use [[ rather than [.
https://mywiki.wooledge.org/BashGuide/TestsAndConditionals#Conditional_Blocks_.28if.2C_test_and_.5B.5B.29

In this case, this is pure appreciated bashism. I like to use the double brackets because of "Using the [[ ... ]] test construct, rather than [ ... ] can prevent many logic errors in scripts. For example, the &&, ||, <, and > operators work within a [[ ]] test, despite giving an error within a [ ] construct." https://www.tldp.org/LDP/abs/html/abs-guide.html#DBLBRACKETS I use `[[ ]]` all the time. Except if the script has already a single bracket, I will not "recode" it with double brackets. > Good Practice: > Whenever you're making a Bash script, you should always use [[ rather than [. https://mywiki.wooledge.org/BashGuide/TestsAndConditionals#Conditional_Blocks_.28if.2C_test_and_.5B.5B.29

jlecour commented

2019-03-21 13:00:48 +01:00

Right, these changes shouldn't have gone in this commit.
And I thought this script was not bash.
I'll remove those changes.

Right, these changes shouldn't have gone in this commit. And I thought this script was not bash. I'll remove those changes.

benpro commented

2019-03-21 14:10:54 +01:00

That would be the contrary. Pure bash. We will not focus on POSIX things. (So you could use &> in evocheck.) ;)

The OpenBSD part should be pure sh, but is not production ready.
OpenBSD has already his branch so I guess we could already delete all things related to OpenBSD, and drop the if debian… But I will wait for @drustan.

That would be the contrary. Pure bash. We will not focus on POSIX things. (So you could use `&>` in evocheck.) ;) The OpenBSD part should be pure sh, but is not production ready. OpenBSD has already his branch so I guess we could already delete all things related to OpenBSD, and drop the `if debian`… But I will wait for @drustan.

evocheck.sh

					
				@ -763,2 +761,3 @@

				                mysql_myisam_indexes mysql_qcache mysql_qcache_mem \

				                mysql_sorts mysql_tmp_tables; do

				                if [[ ! -L /etc/munin/plugins/$file ]]; then