evolix/evocheck
evolix/evocheck
21
2
Fork 2
Code Issues 48 Pull requests 5 Releases 37 Wiki Activity

refactor tests into functions #81

Closed
jlecour wants to merge 6 commits from extract_functions into cleanup
pull from: extract_functions
merge into: evolix:cleanup
Conversation 5 Commits 6 Files changed 1 +1242 -1329
jlecour commented 2019-04-04 20:53:57 +02:00
Owner
Copy link

This one is … a beast !

I have :

  • extracted each test into a function with a corresponding name.
  • removed the default value for the IS_XXX variable. The first occurrence of a IS_XXX is the test itself, which makes it way easier to find.
  • organized variables
  • created a main() function

I have not :

  • changed anything in the tests logic
  • done this work for the OpenBSD section, since it's not sure that it will remain in the script.
This one is … a beast ! I have : * extracted each test into a function with a corresponding name. * removed the default value for the `IS_XXX` variable. The first occurrence of a `IS_XXX` is the test itself, which makes it way easier to find. * organized variables * created a `main()` function I have **not** : * changed anything in the tests logic * done this work for the OpenBSD section, since it's not sure that it will remain in the script.
benpro was assigned by jlecour 2019-04-04 20:53:57 +02:00
jlecour changed title from WIP: redactor tests into functions to refactor tests into functions 2019-04-04 20:54:15 +02:00
benpro commented 2019-04-05 11:48:40 +02:00
Contributor
Copy link

This one is a beast but it's been a long time since I wanted to use functions!
I propose to pair review it.

This one is a beast but it's been a long time since I wanted to use functions! I propose to pair review it.
benpro commented 2019-04-05 11:49:43 +02:00
Contributor
Copy link

Maybe you should redo the pull request to merge into master and not cleanup?
(Or, we will merge it manually into master).

Maybe you should redo the pull request to merge into master and not cleanup? (Or, we will merge it manually into master).
jlecour commented 2019-04-05 15:58:52 +02:00
Author
Owner
Copy link

@benpro I've rebased the branch on master

@benpro I've rebased the branch on master
benpro commented 2019-04-05 16:02:02 +02:00
Contributor
Copy link

The rebase is not the issue. The issue is gitea wanting to compare and merge with cleanup branch.

The rebase is not the issue. The issue is gitea wanting to compare and merge with cleanup branch.
jlecour commented 2019-04-05 18:35:23 +02:00
Author
Owner
Copy link

I've made another PR : #83

I've made another PR : #83
jlecour closed this pull request 2019-04-05 18:35:24 +02:00
Some checks reported errors
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build encountered an error
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
bullseye

   
discussion

This need to be discussed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
suggestion

Suggest to add/change something

  
wontfix

This won't be fixed

No labels
bug
bullseye
discussion
duplicate
enhancement
help wanted
invalid
question
suggestion
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
benpro
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/evocheck#81
No description provided.
Delete branch "extract_functions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?