split-init #9
Loading…
Reference in a new issue
No description provided.
Delete branch "split-init"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
SystemD service + readme update
I don't understand why prevent /etc/init.d/minifirewall :(
We can "map" command to a systemd-unit call, we can write a warning, but I don't see the reason to absolutely prevent it
I have reviewd the entire code changed, for me it can be merged.
There is no regression.
I said in my commit message "Prevent direct call to minifirewall script in favor of systemctl or /etc/init.d/minifirewall stub".
I don't want to prevent direct call to /etc/init.d/minifirewall (which calls systemd as backend) but prevent call to /usr/local/sbin/minifirewall [start|stop|restart].
This is because (for example) if we stop minifirewall by calling the script directly, systemd will not be notified that minifirewall is stopped and will display wrong status information.
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.