split-init #9

Open

whirigoyen wants to merge 7 commits from split-init into master

whirigoyen commented

2022-05-02 16:49:06 +02:00

Owner

SystemD service + readme update

whirigoyen added 3 commits 2022-05-02 16:49:07 +02:00

620331c29d Split init script and code script

286690f94e Add systemd service unit for Minifirewall.

a8b604a900 Update README.md/intall instructions for systemd and new local bin path.

whirigoyen added 1 commit 2022-08-11 16:45:34 +02:00

1f9002f4f3 Prevent direct call to minifirewall script in favor of systemctl or /etc/init.d/minifirewall stub

whirigoyen added 1 commit 2022-08-11 17:10:11 +02:00

f7418fff41 Corrige

whirigoyen added 1 commit 2022-08-12 15:08:32 +02:00

1e98137192 Retire SuccessExitStatus=5 6 inutile

gcolpart commented

2022-08-18 15:32:02 +02:00

Owner

I don't understand why prevent /etc/init.d/minifirewall :(
We can "map" command to a systemd-unit call, we can write a warning, but I don't see the reason to absolutely prevent it

I don't understand why prevent /etc/init.d/minifirewall <action> :( We can "map" command to a systemd-unit call, we can write a warning, but I don't see the reason to absolutely prevent it

👍 1

bwaegeneire commented

2022-08-25 09:51:27 +02:00

Owner

I have reviewd the entire code changed, for me it can be merged.

There is no regression.

I have reviewd the entire code changed, for me it can be merged. There is no regression.

whirigoyen commented

2022-08-25 10:09:02 +02:00

Author

Owner

I said in my commit message "Prevent direct call to minifirewall script in favor of systemctl or /etc/init.d/minifirewall stub".

I don't want to prevent direct call to /etc/init.d/minifirewall (which calls systemd as backend) but prevent call to /usr/local/sbin/minifirewall [start|stop|restart].

This is because (for example) if we stop minifirewall by calling the script directly, systemd will not be notified that minifirewall is stopped and will display wrong status information.

I said in my commit message "Prevent direct call to minifirewall script in favor of systemctl or /etc/init.d/minifirewall stub". I don't want to prevent direct call to /etc/init.d/minifirewall (which calls systemd as backend) but prevent call to /usr/local/sbin/minifirewall [start|stop|restart]. This is because (for example) if we stop minifirewall by calling the script directly, systemd will not be notified that minifirewall is stopped and will display wrong status information.

whirigoyen added 1 commit 2023-01-10 17:52:49 +01:00

f42274341d fix status output (number of # in headers)

jlecour referenced this pull request

2023-10-26 09:18:34 +02:00

[FR] minifirewall utility command #12

This pull request has changes conflicting with the target branch.