Jérémy Lecour jlecour
jlecour pushed to unstable at evolix/ansible-roles 2024-04-12 15:54:33 +02:00
2a264dd2bc redis: replace inline argument with environment variable for the password
jlecour pushed to master at evolix/evocheck 2024-04-09 10:51:37 +02:00
91f0c72286 IS_EVOLIX_GROUP: new check to verify that all Evolix users are in "evolix" group
jlecour pushed to client-functions at evolix/evobackup 2024-04-08 13:15:29 +02:00
9c8dca7b70 update CHANGELOG
jlecour pushed to unstable at evolix/ansible-roles 2024-04-04 18:40:57 +02:00
7a9be8d6fa vrrpd : configure and restart minifirewall before starting VRRP
jlecour pushed to master at evolix/dump-server-state 2024-03-29 10:32:08 +01:00
297cafe04b add guard clauses if dpkg status is missing
jlecour pushed to master at evolix/dump-server-state 2024-03-29 10:31:43 +01:00
8d94752e52 add guard clauses if dpkg status is missing
jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

I'm pretty sure there is a native module for setting the hostname

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

If you use a generic marker, you might keep the default one.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Add a notify

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

replace this with a ansible.builtin.meta: flush_handlers

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We don't store the key there anymore. We will find examples of how we do this in many other roles in ansible-roles.git

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We tend to use systemd instead of the more generic service module. It's less compatibe but more specfic, which is alright in our Debian-centric context.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should use notify and a handler.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Check if command is usable here (I guess it is, since there is no pipe or redirection). command is more safe than shell.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Add a notify

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

replace with command if possible

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should specify the name of the file.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should use a syntax like this :

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We usually prefer to download the file into the ansible role ans use a simple copy in the role. That way we don't depend on the availability of the file when deploying.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Maybe, this shoud become a notify and a handler, to trigger the restart only if changes require a restart have happened.