Patrick Marchand
|
08ef18bc2d
|
Use ${var:+...} instead of [-n ] and "$@" instead of "$*"
Fixes issue uncovered by proper use of double quotes.
|
2018-10-25 11:37:21 -04:00 |
|
|
Patrick Marchand
|
540b7f7278
|
Use ${var:+...} instead of [-n ] and "$@" instead of "$*"
Fixes issue uncovered by proper use of double quotes
|
2018-10-17 16:30:58 -04:00 |
|
|
Patrick Marchand
|
e596e3d520
|
Use $(..) instead of legacy ..
https://github.com/koalaman/shellcheck/wiki/SC2006
modified: scripts/web-add.sh
|
2018-10-16 14:51:50 -04:00 |
|
|
Patrick Marchand
|
97bad77040
|
Add -r to read
I'm less certain about the necessity of this, but if it doesnt cause
problems, I dont see why not.
https://github.com/koalaman/shellcheck/wiki/SC2162
modified: scripts/web-add.sh
|
2018-10-16 14:49:43 -04:00 |
|
|
Patrick Marchand
|
05c9525d7e
|
$/${} is unnecessary on arithmetic variables
https://github.com/koalaman/shellcheck/wiki/SC2004
modified: scripts/web-add.sh
|
2018-10-16 14:46:16 -04:00 |
|
|
Patrick Marchand
|
f4fae90eb1
|
Useless cat
https://github.com/koalaman/shellcheck/wiki/SC2002
modified: scripts/web-add.sh
|
2018-10-16 14:43:26 -04:00 |
|
|
Patrick Marchand
|
5d2d8be5ad
|
Prefer explicit escaping
https://github.com/koalaman/shellcheck/wiki/SC1117
modified: scripts/web-add.sh
|
2018-10-16 14:39:23 -04:00 |
|
|
Patrick Marchand
|
2861d90119
|
Fixes optional group creation
The optional group creation flag in scripts/web-add.sh was never used.
|
2018-10-16 14:35:23 -04:00 |
|
|
Patrick Marchand
|
4aa0332639
|
Use "$@" (with quotes) to prevent whitespace problems
https://github.com/koalaman/shellcheck/wiki/SC2048
modified: web-add.sh
|
2018-10-16 14:32:47 -04:00 |
|
|
Patrick Marchand
|
866f20ef47
|
Adds double quoting to prevent shell globing
modified: web-add.sh
|
2018-10-16 14:28:27 -04:00 |
|
|
Patrick Marchand
|
3e422bc2bf
|
Adds shellcheck source comments
This will allow someone to use shellcheck(1) to automatically check
any referenced code using `shellcheck -x scripts/web-add.sh`
|
2018-10-16 14:10:02 -04:00 |
|