evolix/evocheck
evolix/evocheck
21
2
Fork 2
Code Issues 48 Pull requests 5 Releases 37 Wiki Activity

Fix issue #17 IS_MYSQLUTILS with oracle MySQL5.7 on debian stretch #42

Merged
benpro merged 3 commits from 17-IS_MYSQLUTILS-with-oracle-MySQL5.7 into master 2019-01-18 15:25:13 +01:00
Conversation 7 Commits 3 Files changed 1 +12 -1
benpro commented 2019-01-16 15:25:59 +01:00
Contributor
Copy link
  • MYSQL_ADMIN is now a variable because some installation doesn't have mysqladmin
    user.
  • /usr/bin/mytop or /usr/local/bin/mytop are checked.
- `MYSQL_ADMIN` is now a variable because some installation doesn't have `mysqladmin` user. - `/usr/bin/mytop` or `/usr/local/bin/mytop` are checked.
benpro commented 2019-01-16 15:30:52 +01:00
Author
Contributor
Copy link

@vlaborie Review appreciated! I splitted in three tests for more readability.

@vlaborie Review appreciated! I splitted in three tests for more readability.
benpro added a new dependency 2019-01-16 15:33:25 +01:00
#17 IS_MYSQLUTILS with oracle MySQL5.7 on debian stretch
Ghost commented 2019-01-17 14:56:12 +01:00
First-time contributor
Copy link

Look good but IS_MYSQLUTILS FAILED! emerge multiple time instead of one time.

This can be a good thing if the error show more detail, eg.

  • IS_MYSQLUTILS (.my.cnf) FAILED!
  • IS_MYSQLUTILS (mytop) FAILED!
  • IS_MYSQLUTILS (.mytop) FAILED!
Look good but **IS_MYSQLUTILS FAILED!** emerge multiple time instead of one time. This can be a good thing if the error show more detail, eg. - **IS_MYSQLUTILS (.my.cnf) FAILED!** - **IS_MYSQLUTILS (mytop) FAILED!** - **IS_MYSQLUTILS (.mytop) FAILED!**
benpro commented 2019-01-17 15:49:38 +01:00
Author
Contributor
Copy link

Hmmm. Yes but in verbose mode?
I could break if not in verbose?

Hmmm. Yes but in verbose mode? I could break if not in verbose?
Ghost commented 2019-01-18 14:03:40 +01:00
First-time contributor
Copy link

Yes it make more sense in verbose mode, a break is a good idea.

Yes it make more sense in verbose mode, a break is a good idea.
benpro commented 2019-01-18 15:15:48 +01:00
Author
Contributor
Copy link

I have done the verbose part. I cannot find a way of breaking properly...

I have done the verbose part. I cannot find a way of breaking properly...
benpro commented 2019-01-18 15:16:26 +01:00
Author
Contributor
Copy link

Exemple output:

root@evocheck:~# VERBOSE=1 /usr/share/scripts/evocheck.sh
IS_MYSQLUTILS FAILED!
mytop binary missing
IS_MYSQLUTILS FAILED!
debian-sys-maint missing in /root/.mytop
Exemple output: ```text root@evocheck:~# VERBOSE=1 /usr/share/scripts/evocheck.sh IS_MYSQLUTILS FAILED! mytop binary missing IS_MYSQLUTILS FAILED! debian-sys-maint missing in /root/.mytop ```
Ghost commented 2019-01-18 15:18:21 +01:00
First-time contributor
Copy link

LGTM

LGTM
benpro closed this pull request 2019-01-18 15:25:13 +01:00
benpro deleted branch 17-IS_MYSQLUTILS-with-oracle-MySQL5.7 2019-01-18 15:25:19 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
bullseye

   
discussion

This need to be discussed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
suggestion

Suggest to add/change something

  
wontfix

This won't be fixed

No labels
bug
bullseye
discussion
duplicate
enhancement
help wanted
invalid
question
suggestion
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#17 IS_MYSQLUTILS with oracle MySQL5.7 on debian stretch
evolix/evocheck
Reference: evolix/evocheck#42
No description provided.
Delete branch "17-IS_MYSQLUTILS-with-oracle-MySQL5.7"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?