evolix/minifirewall
21
0
Fork 0
Code Issues 4 Pull requests 3 Releases 1 Activity

rewrite code structure and support includes #8

Open
jlecour wants to merge 0 commits from includes into master
pull from: includes
merge into: evolix:master
Conversation 3 Commits - Files changed -
jlecour commented 2021-05-22 23:27:47 +02:00
Owner
Copy link

The main goal is to move all custom iptable/ip6table code to files inside /etc/default/minifirewall.d/.

With this, we can simplify the main configuration with just IP/ports configurations, and all other rules can be added/modified in dedicated files. It helps a lot with Ansible.

Also, some shellcheck violations have been fixed, a few code snippets have been extracted into functions, some variables have been renamed to be more expressive.

The main goal is to move all custom `iptable`/`ip6table` code to files inside `/etc/default/minifirewall.d/`. With this, we can simplify the main configuration with just IP/ports configurations, and all other rules can be added/modified in dedicated files. It helps a lot with Ansible. Also, some shellcheck violations have been fixed, a few code snippets have been extracted into functions, some variables have been renamed to be more expressive.
jlecour added 15 commits 2021-05-22 23:27:53 +02:00
bwaegeneire commented 2021-05-24 12:06:49 +02:00
Owner
Copy link

Plusieurs fix, dont find qui est remplacé par un pathname expension () car il ne gére pas les espaces :
Several fixes, including find which is replaced by a pathname expension () because it doesn't handle spaces in filenames:

https://paste.evolix.org/?6cf81d417e09efba#6MR5Wy9NKUQkUbY9VKzuEo58viDXmCF1ZjidzT9WGkrw

Plusieurs fix, dont find qui est remplacé par un pathname expension (*) car il ne gére pas les espaces : Several fixes, including find which is replaced by a pathname expension (*) because it doesn't handle spaces in filenames: https://paste.evolix.org/?6cf81d417e09efba#6MR5Wy9NKUQkUbY9VKzuEo58viDXmCF1ZjidzT9WGkrw
jlecour commented 2021-05-24 21:34:11 +02:00
Author
Owner
Copy link

The pathname expansion does not exclude files with a dot. It is important to do so.

I know find dos'nt work well with spaces, but in this kind of sitiation, it seems like an acceptable tradeoff.

The pathname expansion does not exclude files with a dot. It is important to do so. I know find dos'nt work well with spaces, but in this kind of sitiation, it seems like an acceptable tradeoff.
bwaegeneire commented 2021-05-26 11:24:22 +02:00
Owner
Copy link

The pathname expansion does not exclude files with a dot. It is important to do so.

It does exlcude it in dash, bash in POSIX mode (and regular bash), it isn't in POSIX spec tho. Here is a exemple with dash https://paste.evolix.org/?e12aaaeec0dcb027#6ifCVYbvLmhYXhzXN7UCBXuwUKmmxi7dVWfc19iBKbJw

> The pathname expansion does not exclude files with a dot. It is important to do so. It does exlcude it in dash, bash in POSIX mode (and regular bash), it isn't in POSIX spec tho. Here is a exemple with dash https://paste.evolix.org/?e12aaaeec0dcb027#6ifCVYbvLmhYXhzXN7UCBXuwUKmmxi7dVWfc19iBKbJw
jlecour added 4 commits 2021-05-26 13:23:47 +02:00
jlecour added 2 commits 2021-06-04 14:07:31 +02:00
jlecour added 1 commit 2021-06-04 14:08:12 +02:00
jlecour added 2 commits 2021-09-06 14:33:06 +02:00
jlecour added 2 commits 2021-09-06 14:33:39 +02:00
lpoujol added 2 commits 2021-09-14 09:12:46 +02:00
lpoujol added 1 commit 2021-09-14 09:45:30 +02:00
jlecour added 1 commit 2021-09-14 11:06:15 +02:00
jlecour added 4 commits 2021-09-14 12:47:42 +02:00
48983bfa2d fix mistakes 
* forgotten chains
* wrong variable names
* baf field separator for awk
lpoujol changed title from WIP: rewrite code structure and support includes to rewrite code structure and support includes 2021-12-03 09:52:01 +01:00
lpoujol added 1 commit 2021-12-03 11:30:11 +01:00
jlecour force-pushed includes from 48b78fb97c to e7aaefef9a 2021-12-06 17:32:34 +01:00 Compare
jlecour added 1 commit 2021-12-11 10:13:51 +01:00
jlecour force-pushed includes from 28a6346ef9 to aada44e1f2 2022-03-15 16:32:24 +01:00 Compare
This branch is already included in the target branch. There is nothing to merge.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin includes:includes
git checkout includes

Merge

Merge the changes and update on Forgejo.
git checkout master
git merge --no-ff includes
git checkout master
git merge --ff-only includes
git checkout includes
git rebase master
git checkout master
git merge --no-ff includes
git checkout master
git merge --squash includes
git checkout master
git merge --ff-only includes
git checkout master
git merge includes
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: evolix/minifirewall#8
No description provided.
Delete branch "includes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?