Jérémy Lecour jlecour
jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Add a notify

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

replace this with a ansible.builtin.meta: flush_handlers

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We don't store the key there anymore. We will find examples of how we do this in many other roles in ansible-roles.git

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We tend to use systemd instead of the more generic service module. It's less compatibe but more specfic, which is alright in our Debian-centric context.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should use notify and a handler.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Check if command is usable here (I guess it is, since there is no pipe or redirection). command is more safe than shell.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Add a notify

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

replace with command if possible

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should specify the name of the file.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

You should use a syntax like this :

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

We usually prefer to download the file into the ansible role ans use a simple copy in the role. That way we don't depend on the availability of the file when deploying.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

Maybe, this shoud become a notify and a handler, to trigger the restart only if changes require a restart have happened.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

you could put owner/group/mode in the task, instead of the loop. It's better fr readability.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

you should use a more specific variable name to avoid collision. For this kind of very local usage.

jlecour commented on pull request evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

maybe add a comment to clarify why we only deal with the main domain, and what should be done (if any) for others.

jlecour suggested changes for evolix/ansible-roles#176 2024-03-25 07:52:03 +01:00
WIP: jitsimeet

I didn't spot any big issue. And I guess y'ouve tried the playbook many times.

jlecour pushed to client-functions at evolix/evobackup 2024-03-22 11:32:27 +01:00
699ed5a781 use $TMPDIR if available
jlecour merged pull request evolix/evobackup#72 2024-03-22 11:27:36 +01:00
fix-tempfiles
jlecour pushed to master at evolix/evobackup 2024-03-22 11:27:36 +01:00
859bb800d4 Merge pull request 'fix-tempfiles' (#72) from fix-tempfiles into master
21533c6fb9 client: Write temporary files in /tmp
9510546d48 client: Correctly clean up temporary files
Compare 3 commits »
jlecour commented on pull request evolix/ansible-roles#176 2024-03-21 14:13:36 +01:00
WIP: jitsimeet

Variable names should be prefixed with the role's name.

I would rename like this :

  • system_dep → jitsimeet_system_dependencies
  • domains → jitsimeet_domains
  • turn_domains →…