We don't store the key there anymore. We will find examples of how we do this in many other roles in ansible-roles.git
We tend to use systemd
instead of the more generic service
module. It's less compatibe but more specfic, which is alright in our Debian-centric context.
Check if command
is usable here (I guess it is, since there is no pipe or redirection). command
is more safe than shell
.
We usually prefer to download the file into the ansible role ans use a simple copy in the role. That way we don't depend on the availability of the file when deploying.
Maybe, this shoud become a notify
and a handler, to trigger the restart only if changes require a restart have happened.
you could put owner
/group
/mode
in the task, instead of the loop. It's better fr readability.
you should use a more specific variable name to avoid collision. For this kind of very local usage.
maybe add a comment to clarify why we only deal with the main domain, and what should be done (if any) for others.
Variable names should be prefixed with the role's name.
I would rename like this :
- system_dep → jitsimeet_system_dependencies
- domains → jitsimeet_domains
- turn_domains →…